python310Packages.pygobject: don't propagate cairo dev dependencies#252613
Merged
mweinelt merged 1 commit intoNixOS:stagingfrom Feb 17, 2024
Merged
python310Packages.pygobject: don't propagate cairo dev dependencies#252613mweinelt merged 1 commit intoNixOS:stagingfrom
mweinelt merged 1 commit intoNixOS:stagingfrom
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 501+
Member
|
This diff --git a/pkgs/applications/version-management/meld/default.nix b/pkgs/applications/version-management/meld/default.nix
index 224efe8c1ac2..5c7ca1336baf 100644
--- a/pkgs/applications/version-management/meld/default.nix
+++ b/pkgs/applications/version-management/meld/default.nix
@@ -48,8 +48,8 @@ python3.pkgs.buildPythonApplication rec {
];
propagatedBuildInputs = with python3.pkgs; [
- pygobject3
- pycairo
+ pygobject3.out
+ pycairo.out
];
postPatch = ''would be better It was definitely a big mistake to use |
jtojnar
reviewed
Aug 31, 2023
Member
Author
|
How do we want to solve this? |
jtojnar
reviewed
Jan 27, 2024
After this change applications like emote no longer depend on -dev outputs
SuperSandro2000
force-pushed
the
pygobject
branch
from
6852dc9 to
e0d3d07
Compare
jtojnar
approved these changes
Jan 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After this change applications like emote no longer depend on -dev outputs.
Tested by using nix-tree and comparing the runtime dependencies.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)